Open geclick opened 6 months ago
@geclick Sorry I didn't get notified of this issue on time. I am just seeing it now. I am currently looking into it at the moment
@geclick the problem is the resolve_permission
method. I don't use the resolver
method provided in the Ninja
model schema. The problem with that being called twice is likely a problem from pydantic. I know I faced that problem once but I can't remember where.
You can only solve this problem using pydantic model validator at mode='before'. Check the example below.
class ModelAuthReadSchema(ModelSchema):
permissions: List[str] | None
class Meta:
model = AuthModel
fields = ['id', 'username', 'first_name', 'last_name', 'email']
@model_validator(mode="before")
def validate_permission_list(cls, values: DjangoGetter) -> typing.Any:
values = values._obj
if isinstance(values, dict):
# values will have ['id', 'username', 'first_name', 'last_name', 'email']
user = None # add functionality to get the user
permissions = get_permissions(user)
values.update(permissions=permissions)
return values
@geclick the problem is the
resolve_permission
method. I don't use theresolver
method provided in theNinja
model schema. The problem with that being called twice is likely a problem from pydantic. I know I faced that problem once but I can't remember where.You can only solve this problem using pydantic model validator at mode='before'. Check the example below.
class ModelAuthReadSchema(ModelSchema): permissions: List[str] | None class Meta: model = AuthModel fields = ['id', 'username', 'first_name', 'last_name', 'email'] @model_validator(mode="before") def validate_permission_list(cls, values: DjangoGetter) -> typing.Any: values = values._obj if isinstance(values, dict): # values will have ['id', 'username', 'first_name', 'last_name', 'email'] user = None # add functionality to get the user permissions = get_permissions(user) values.update(permissions=permissions) return values
tnks
@geclick can you close this issue if the problem is resolved?
I am adding a 'user' key to the token claims with the user data including its permissions. Following exactly this I get the tokens with no problem. But resolving the permissions raises a ValidationError, and I realized that the resolver gets called twice: -first time the obj is a User instance and context is None, so no problem for getting the permission list -the second time obj is not a User but a ModelAuthReadSchema instance and context is not None but its user is a AnonymousUser, and here comes the errors
this is my schema for User where AuthModel is just get_user_model()
get_permissions is a custom function for getting just business-related permissions
this is the error:
this would be the desired output: