eafer / rdrview

Firefox Reader View as a command line tool
Apache License 2.0
836 stars 35 forks source link

update Makefile #2

Closed Millak closed 3 years ago

eafer commented 3 years ago

You are right, it should be /usr/local/bin. I didn't know /usr/bin was for the distro alone. I don't think I like the "make check" addition because it doesn't allow you to run Valgrind, but I will pick up the rest.

I'm very fastidious with my git history, so I prefer to commit patches myself instead of using github pull requests. I'll credit you by name, but I think you need to give me your email if you want github to link the contribution back to you. Let me know if that matters to you.

Millak commented 3 years ago

I wasn't sure about the make check part. On one hand it's fairly common, on the other hand it doesn't make it easy to switch between ./check and ./check -V. And I'm still working on the test suite in Guix's isolated test environment.

not an issue on the commits, my email is efraim@flashner.co.il

eafer commented 3 years ago

Ok, it's done. Thank you!