eafer / rdrview

Firefox Reader View as a command line tool
Apache License 2.0
836 stars 35 forks source link

Question: Does rdrview also support images? #22

Closed dorneanu closed 2 years ago

dorneanu commented 2 years ago

Hi! First of all: Awesome tool. I use it to extract readable part from URLs and convert that to epub (see blog post).

However: In my epub's I somehow miss pictures. I haven't investigated yet (might be pandocs fault) but could it be that rdrview filters out images?

Cheers, Victor

dorneanu commented 2 years ago

I've just found rdrview does actually include img tags but when converting the HTML to epub (using pandoc) the images are gone. I know that pandoc has this option:

--self-contained
Produce a standalone HTML file with no external dependencies, using data: URIs to incorporate the contents of linked scripts, stylesheets, images, and videos.

Is there any chance to add sth similar to rdrview as well?

eafer commented 2 years ago

First of all: Awesome tool. I use it to extract readable part from URLs and convert that to epub

Thanks! I'm glad that you like it.

I've just found rdrview does actually include img tags but when converting the HTML to epub (using pandoc) the images are gone.

I'm not sure I understand the problem. I've never used pandoc, but if you set the --self-contained option when working with the output of rdrview, shouldn't pandoc retrieve the images itself?

dorneanu commented 2 years ago

Yes, you're right. pandoc retrieves the images by itself. No need to add this to rdrview. Sorry for the confusion.

I'll close this one.