search

eafer / rdrview

Firefox Reader View as a command line tool
Apache License 2.0
836 stars 35 forks source link

versioning #29

Closed aecepoglu closed 1 year ago

aecepoglu commented 1 year ago

rdrview doesn't have a version yet. I am packaging it for Guix and I'd like to be able to refer to a version number in the package definition.

Can we add a 0.1.0 version?

eafer commented 1 year ago

Can we add a 0.1.0 version?

I don't mind, what do you need me to do? Change the output of --version? Right now I just use the commit ids.

aecepoglu commented 1 year ago

I think a simple sensible git tag would do. If we are at 0.1.0 then 0.1.0

(also I apologise for responding as late as I am doing)

eafer commented 1 year ago

I think a simple sensible git tag would do. If we are at 0.1.0 then 0.1.0

I pushed this a few days ago, but for some reason my email replies aren't showing up in github.

eafer commented 1 year ago

I think a simple sensible git tag would do. If we are at 0.1.0 then 0.1.0

Ok, I just pushed that.

eafer commented 1 year ago

I think a simple sensible git tag would do. If we are at 0.1.0 then 0.1.0

I pushed that a few days ago, but my email reply didn't make it to github for some reason.

aecepoglu commented 1 year ago

I have a guix pkg definition at hand and will make an effort to submit it some time :) Considering how long it takes me to respond here, I could say it will take me another few weeks before I have done that.