search

eafer / rdrview

Firefox Reader View as a command line tool
Apache License 2.0
836 stars 35 forks source link

fix OpenBSD compiler command #30

Closed Veraellyunjie closed 4 months ago

Veraellyunjie commented 1 year ago

On OpenBSD 7.1 gcc is installed as egcc

pkg_info -L gcc
...
/usr/local/bin/egcc
...

With original Makefile you get:

gmake: gcc: No such file or directory

Make Makefile aware of it

Also, original README.md doesn't mention the gcc among tools to be installed

eafer commented 1 year ago

Thanks for the report. Will your patch break the build for older releases of OpenBSD, or do they provide egcc as well?

Veraellyunjie commented 1 year ago

Me, I am not that knowledgeable to be honest.

The internet suggests that gcc had been the default compiler shipped with OpenBSD base before they switched to clang. egcc has been gcc from ports/packages.

https://unix.stackexchange.com/a/554754

gcc was removed from the OpenBSD base system on amd64 in late 2021 (OpenBSD 7.0).

Indeed:

http://man.openbsd.org/OpenBSD-6.9/gcc

gcc, g++, cc, c++ - GNU project C and C++ compiler

http://man.openbsd.org/OpenBSD-7.0/gcc

No results found.

That stackexchange answer itself is from 2019 and it says that that year there were both gcc (version 4.2.1 20070719) and egcc (version 8.3.0)

egcc is mentioned as early as 1999 on the mailing list: https://marc.info/?l=openbsd-ports&m=92550165814346&w=2

Officially supported are 2 OpenBSD releases, now 7.1 and 7.0.
7.2 is due this month, when 7.0 retires. So, officially older releases are not cared about. There are plenty of older releases still powering machines though...

eafer commented 4 months ago

Sorry for the long delay. I guess the change makes sense, though maybe I should have made it easier to pick your own compiler for the build. Thanks for the patches.