eagleflo / mpyq

Python library for reading MPQ archives.
BSD 2-Clause "Simplified" License
99 stars 23 forks source link

Fix the unit tests. #33

Closed tewalds closed 5 years ago

tewalds commented 5 years ago

Fix the unit tests, by mocking stdout and closing the replay file properly. Make the unit test runnable. Also improve setup.py with the extra dependencies.

eagleflo commented 5 years ago

Looks good! I'd like to use the built-in https://docs.python.org/3/library/unittest.mock.html with Python 3, so mock would become a conditional dependency for Python 2.x.

Tiny nitpick: the commit title is a bit long. Fix the unit tests would be a better title, with the rest pushed into the commit message itself.

tewalds commented 5 years ago

Done.

eagleflo commented 5 years ago

Thank you!