schematic review - Githubissues

eagletrt / handcart-hw

🛒 Hardware for Fenice's charging handcart

1 stars 1 forks source link

schematic review #12

Closed thomasnonis closed 9 months ago

thomasnonis commented 10 months ago

General

[x] use a 0.050 in grid (realign everything after changing it)
[x] Rnets are 4x0603, not 4x0612
[x] specify the unit of resistor values (e.g. 22 -> 22R)
[x] Add feedbacks for every single stupid signal (within reason, possibly analog)
[x] RASPI with a "I", not "Y"
[x] Place connectors together with their respective circuits in their sheets
[x] Don't use custom symbols if not needed. Also keep body diode

Power

[x] if +12V rail is used just for SDC, use VSD label
[x] consider 2 separate fuses, one fo +12V and one for VSD
[x] place PWR_FLAGs at power net sources
[x] add LEDs for every generated power rail
[x] add fuse on main power input
[x] add fuse or pptc on dcdc2510 output
[x] TSAL must be supplied by 24V
[x] consider removing 12V aux supply from charger connector and replace them with spares. Then add spare power supply connector

Connectors

[x] add transient voltage protections (TVS) on all I/Os that interface with external systems/humans
[x] add LPF and over/undervoltage protection (diode shunts) on all inputs
[x] name every connector
[x] why BMS is powered by 12V?
[x] why does J10 have 6 pins instead of 4?
[x] Molex outputs is not a great descriptive name. Just outputs would be better

Shutdown

[ ] consider finding new relay for 24V operation
[x] why this specific mosfet to drive the relay? Consider 2N7002 which is already used in other circuits
[x] both nets are inputs?
[x] SD diode probably useless
[x] Consider placing relay directly after VDC generation

Discharge

[x] why here pull-down is 10k and in other parts is 330k?
[x] Don't use R_Small symbols. There is plenty of space, no need to make everything hyper compact

Raspberry

[x] consider adding a solder jumper on the 3V3 rail of the RPI. It has an internal regulator, which might interfere with the TexDCDC and result in unnecessary problems or power draw
[x] Why 10k as I2C pull-up?

Output

[x] Why gate series resistors are 22R while they are 33R in other places?
[x] Why 2512 resistors for just 200mW?
[x] use TSAL in easy mode (just send on-off signal)
[ ] think about power dissipation of all mosfets
[x] no addressable LED strips :(

Kirseline commented 10 months ago

[x] Add reverse polarity protection on main power input
[x] different CS for different spi chips
[x] lower filter frequency on shutdown feedback