search

eahlys / EdPaste

Laravel/PHP-driven Pastebin with users management
MIT License
38 stars 14 forks source link

Refactor some #4

Closed nickescobedo closed 6 years ago

nickescobedo commented 6 years ago

Hello @Edraens I found your package while exploring GitHub and made some changes.

First, I moved the validation into a form request validation. This makes updating and reading the code easier. Second, I cleaned up the submit method some in the PasteController. If you do decide to merge this please verify everything still works correctly after these changes.

I can make some more updates if you're interested. Some additional items I was thinking is to further break apart the submit method and the other methods in the PasteController to really separate concerns.

eahlys commented 6 years ago

Hi ! Thanks for your work. I planned to refactor all the code (infact, EdPaste is my first real project, I was learning Laravel with this one) because a lot of things were kind of dirty. I really appreciate your work ! I'll merge into Edraens/refactor and do some tests.

Thanks.

eahlys commented 6 years ago

Everything is working. Thanks :)

nickescobedo commented 6 years ago

@Edraens want me to do more? If not, no problem. Let me know. 😄