search

eak24 / onshapepy

The OnShape Python package.
MIT License
5 stars 1 forks source link

Create "Measure" FS studio that can take all measurements needed #14

Closed eak24 closed 6 years ago

eak24 commented 6 years ago

This issue is for further collaboration on the Measure FeatureScript Studio. The goal is to develop a feature that can take complex measurements depending on the entities being selected, much like the way the "measurement tool" on the lower right of the UI dynamically reports relevant measurements. To see the discussion that spawned this, go here.

Next step: merge "Measure Distance" and "Measure Area" into one "Measure" function that dynamically decides whether to measure distance or area based on the selected elements.

eak24 commented 6 years ago

So far we store all the measurements into a "measurements" context variable.

mbartlett21 commented 6 years ago

@ethan92429 Would this be a suitable featurescript to use? https://cad.onshape.com/documents/e048d057f445affb6a3af03a

eak24 commented 6 years ago

Hi @morganb21! I can't seem to access the document you linked... This is one that I've worked on and now works with onshapepy. It could use improvements, but it works alright for now.

eak24 commented 6 years ago

Actually, I think the one I linked is good enough to close this!

mbartlett21 commented 6 years ago

@ethan92429 Sorry, i forgot to make it public :smile: It should work now. It has length, angle, distance, diameter, radius, and it is in the format of the default variable feature

eak24 commented 6 years ago

@morganb21 this is great! Thanks! We'll definitely use this one.

mbartlett21 commented 6 years ago

@ethan92429 It can put this into a variable called #m that is a map