search

ealeksandrov / EAIntroView

Highly customizable drop-in solution for introduction views.
MIT License
3.76k stars 501 forks source link

Fixed constraints for custom skip button Y position. #129

Closed Woildan closed 8 years ago

Woildan commented 9 years ago

When setting the skipButtonY property the skip button wasn't clickable anymore because a height constraint of 0 was created for the button. I fixed by not creating any height constraint for the button so Auto Layout uses the button intrinsic content size.

wdcurry commented 8 years ago

This issue is not fully corrected. On ViewDidLoad, if you set skipButtonY, the button will not respond. If you set this in ViewDidAppear, it works.

ealeksandrov commented 8 years ago

@wdcurry I tried it in viewDidLoad and this fix works for me. So I am accepting this PR, let me know if you still have any issues.

wdcurry commented 8 years ago

It must be something local at my end, but my solution works fine, so sure thing.. cheers!