[Bug/Feature Request] Dark mode support

ealeksandrov / ProvisionQL

Quick Look plugin for mobile apps and provisioning profiles

MIT License

2.35k stars 147 forks source link

[Bug/Feature Request] Dark mode support #28

Closed 916253 closed 5 years ago

916253 commented 5 years ago

Dark mode on macOS Mojave causes the text to change colors, but the background color remains the same, resulting in clashing colors which causes the text to become unreadable:

ealeksandrov commented 5 years ago

Strange, dark mode looks fine for me:

(+ https://github.com/ealeksandrov/ProvisionQL/issues/27#issuecomment-453034801)

macOS 10.14.3

916253 commented 5 years ago

Interesting-- I tried this on multiple machines, one on 10.14.3, and another on 10.14.4 Beta (18E194d) both exhibited the same results. Would it be possible for you to force the plugin to always use light mode (via bool NSRequiresAquaSystemAppearance or similar)?

(In the meantime, I got lazy and just settled on setting the background color on my local copy to a color that doesn't conflict with the text in either mode, lol)

ealeksandrov commented 5 years ago

I don't remember doing any special settings, but I'll check on other macs anyway.

Thanks for sharing your solution :)

ealeksandrov commented 5 years ago

Full dark mode support added in #29 and released in 1.6.0 on Homebrew Cask.

Let's see if it fixes all your cases :)

916253 commented 5 years ago

Hey-- sorry for the super late response Yeah, that seems to have fixed everything, awesome!