search

ealush / emoji-picker-react

The most popular React Emoji Picker
https://ealush.com/emoji-picker-react/
MIT License
1.04k stars 171 forks source link

Hide emojis by unicode #336

Closed nati-elmaliach closed 1 year ago

nati-elmaliach commented 1 year ago

Let's start with hiding unicode, for example unicodeToHide={[ '1f4a3'] }. https://github.com/ealush/emoji-picker-react/assets/45143653/88a529a6-15e0-4a68-8fa0-2ed9d9afdfe5

ealush commented 1 year ago

Overall, good job. I left a few comments. Let's take care of these, and then we can move to the rest of the feature.

nati-elmaliach commented 1 year ago

@ealush, np.

So let's use this PR to exclude those 404 emojis that doesn't load, do you want to hardcode them into unicodeToHide ? do you have a list of those emojis ?

Next step could be the configuration

ealush commented 1 year ago

I am sorry for taking the time, @nati-elmaliach. This looks great, and I think we can move forward with this by removing the failing emojis to begin with. I'll merge this for now as it seems to be exactly what we need. I won't bump the version just yet, but I'll only do it once we actually remove the missing emojis.