ealush / emoji-picker-react

The most popular React Emoji Picker
https://ealush.com/emoji-picker-react/
MIT License
1.04k stars 171 forks source link

chore: upgrade to sb7 for support node 20 #373

Open shootermv opened 10 months ago

shootermv commented 10 months ago

what im trying to do here: For make the storybook run on node 20 - im upgrading storybook to its latest version the 7

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emoji-picker-react ❌ Failed (Inspect) Nov 9, 2023 1:36pm
ealush commented 9 months ago

@shootermv, ok there's some progress. Thanks for following up on your PR.

We passed the install/build stage - but now I am seeing another issue when trying to run storybook. I am assuming there's a bit more tweakign to do, but not much. LMK if you need me to step in and take a look as well.

image

shootermv commented 9 months ago

Totally. As far as i can see - it is something with typescript transpilation Someone recommended me to move to vite from tsdx. He pointed out that tsdx is not maintened anymore Is it something that can taake place (in your opinion)?

On Sun, Nov 12, 2023, 16:50 Evyatar @.***> wrote:

@shootermv https://github.com/shootermv, ok there's some progress. We passed the install/build stage - but now I am seeing another issue when trying to run storybook.

[image: image] https://user-images.githubusercontent.com/11255103/282306377-1357033d-1afe-4e78-8dd4-6c9a5faf6092.png

— Reply to this email directly, view it on GitHub https://github.com/ealush/emoji-picker-react/pull/373#issuecomment-1807149532, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKGMHQXRZBROTFJ3QMT2TLYEDOZ5AVCNFSM6AAAAAA7CN3VH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBXGE2DSNJTGI . You are receiving this because you were mentioned.Message ID: @.***>

ealush commented 9 months ago

@shootermv yes, if you have the time and the will to migrate to vite, I will very much appreciate this effort