search

ealush / emoji-picker-react

The most popular React Emoji Picker
https://ealush.com/emoji-picker-react/
MIT License
991 stars 166 forks source link

The EmojiPicker caches the old onEmojiClick method #400

Open weiningning opened 4 months ago

weiningning commented 4 months ago

Hello, I encountered an issue while using the EmojiPicker component: When the props onEmojiClick of the EmojiPicker component are changed, the EmojiPicker does not update and caches the old onEmojiClick method. I am expecting the EmojiPicker to use the new onEmojiClick function when the props onEmojiClick are changed.

ealush commented 4 months ago

Hi, do you have a reproduction?

I can confirm it used to be an issue. Wondering if it came back due to a regression.

stonelens commented 2 months ago

I'm encountering a similar issue while using v4.9.2, and I believe it behaves quite the same as the issue https://github.com/ealush/emoji-picker-react/issues/365, the onEmojiClick function cannot access latest component state even I wrap my click handler with a callback hook

Diegocndd commented 1 month ago

same problem here. any update?