search

eamigo86 / graphene-django-extras

Extras functionalities for Graphene-Django
MIT License
416 stars 105 forks source link

Compatibility Django 2 #66

Open Ouradze opened 6 years ago

Ouradze commented 6 years ago

Hello,

Django-filters version has been pinned to 1.1 due to its incompatibility with django 2 (I assume). As the version 2 has been released, do you know what would be needed to have it updated such that we could use graphene-django-extras with django 2 or is it compatible out of the box ?

Thanks

eamigo86 commented 6 years ago

Hi @eclar, thanks for ask. Right now, in my free time, I'm working on a new version of graphene-django-extras tested with django 2.1, in this new version there are many new features implemented and many issues reported corrected.

Ouradze commented 6 years ago

Thanks for your answer. Do you have any idea when a version compatible with Django2 will be released ?

eamigo86 commented 6 years ago

Well, the exact date could not tell you, but I think that within 10 days it will be available

Ouradze commented 6 years ago

Perfect, thanks !

aldarund commented 6 years ago

@eamigo86 graphene-django merged PR for django-filters2, will be released on pypi today or tomorrow https://github.com/graphql-python/graphene-django/pull/492#issuecomment-418705569

eamigo86 commented 6 years ago

Hi @aldarund , Thanks for the news, I am following very closely the changes in graphql-python, graphene and graphene-django :+1:

syrusakbary commented 6 years ago

A new version of graphene_django: 2.2.0 is now live on PyPI

eamigo86 commented 6 years ago

Hi @syrusakbary , thanks for the great news !!!!

gvbkr commented 5 years ago

@eamigo86 can you please update when you will release the Django 2.1 support? I am starting a new project and would really like to use this package and do not wnat to downgrade Django. I am running into issues when I try to install this package in my project using Django 2.1.

I ran into a few issues like the ones below which I tried to resolve, but couldn't.

File "/root/Envs/dhan_venv/lib/python3.6/site-packages/django_filters/filters.py", line 9, in from django.db.models.sql.constants import QUERY_TERMS ImportError: cannot import name 'QUERY_TERMS'

I fixed this by following your suggestion to manually upgrade django-filter to 2.0.0 but then I ran into this issue.

AttributeError: 'Registry' object has no attribute 'get_type'