eamodio / vscode-find-related

Finds files related to the current file based on user-defined configuration rules in VS Code
MIT License
30 stars 12 forks source link

Don't open file until selected #20

Closed Peeja closed 1 year ago

Peeja commented 4 years ago

Issue Type: Bug

  1. Open a file which has related files.
  2. Run Show Related Files.

Expected: No files should have opened. Actual: The first (and therefore selected) file has opened, behind the list of related files.

  1. Select another related file with Up/Down or Ctrl-P/Ctrl-N.

Expected: No files should have opened. Actual: The selected file has opened, behind the list of related files.

I think findrelated.autoPreview is maybe supposed to control this behavior (although I'm not certain that's what it means), but in any case, I have it set to false and still see this.

Extension version: 0.9.0 VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:57:51.166Z) OS version: Darwin x64 18.7.0

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|1, 2, 2| |Memory (System)|16.00GB (0.61GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
tdegrunt commented 2 years ago

Isn't this "findrelated.autoOpen": true ?

eamodio commented 1 year ago

Can you still reproduce this in the latest pre-release edition? It should not happen if you set findrelated.autoPreview to false.

You can switch to the pre-release edition, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

github-actions[bot] commented 1 year ago

This issue needs more information and has not had recent activity. Please provide the missing information or it will be closed in 7 days. Thanks!

github-actions[bot] commented 1 year ago

Closing this issue because it needs more information and has not had recent activity. Please re-open this issue if more details can be provided. Thanks!

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.