eamodio / vscode-find-related

Finds files related to the current file based on user-defined configuration rules in VS Code
MIT License
30 stars 12 forks source link

With "Open Side By Side" enabled, split panes are continually added #23

Open forivall opened 4 years ago

forivall commented 4 years ago

Issue Type: Bug

Steps to Reproduce:

  1. Find related -> open file
  2. Do it again on the new file, selecting what was the original file
  3. Expected: it should focus on the original file, instead, it opens a new split pane to the right.

Also, it takes a reload for changes to the "Open Side By Side" option to take effect, which is more of an annoying quirk.

Extension version: 0.9.0 VS Code version: Code 1.43.0 (78a4c91400152c0f27ba4d363eb56d2835f9903a, 2020-03-09T19:34:44.548Z) OS version: Darwin x64 18.7.0

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-3470S CPU @ 2.90GHz (4 x 2900)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled| |Load (avg)|2, 2, 2| |Memory (System)|32.00GB (1.17GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
Settings ```json "findrelated.rulesets": [ { "name": "js", "rules": [ { "pattern": "(.+)\/([^\/]+?)\\.([tj]sx?)$", "locators": [ "$1/{test,tests,__tests__,__test__}/$2{.spec,.test,}.$3" ] }, { "pattern": "src/(.+)\/([^\/]+?)\\.([tj]sx?)$", "locators": [ "src/$1/{test,tests,__tests__,__test__}/$2{.spec,.test,}.$3", "{test,tests,__tests__,__test__}/$1/$2{.spec,.test,}.$3", ] }, { "pattern": "(.+)\/(?:tests?|__tests?__)\/((?:.+?/)?(?:[^\/]+?))(?:\\.spec|\\.test)?\\.([tj]sx?)$", "locators": [ "$1/$2.$3", "src/$1/$2.$3" ] }, { "pattern": "(?:tests?|__tests?__)\/((?:.+?/)?(?:[^\/]+?))(?:\\.spec|\\.test)?\\.([tj]sx?)$", "locators": [ "$1.$2", "src/$1.$2" ] } ] } ], "findrelated.applyRulesets": [ "aspnet", "aspnet-mvc", "aurelia", "c/c++", "csharp", "minified", "xaml", "js" ], "findrelated.openSideBySide": true, ```
Gregory108 commented 2 years ago

And even further: adding "workbench.editor.revealIfOpen": true, does not solve the problem