search

eamodio / vscode-toggle-excluded-files

Quickly toggles excluded (hidden) files visibility in the file explorer in VS Code
MIT License
36 stars 8 forks source link

Wrong settings.json handling #10

Closed myfairsyer closed 5 years ago

myfairsyer commented 5 years ago

vscode-toggle-excluded-files doesn't handle vscode's user setting correctly.

  1. It directly parses settings.json instead of accessing settings via configuration API in vscode.d.ts
  2. It parses them as regular JSON although vscode settings files are "JSONC" and allow comments and trailing commas (MS's jsonc parser)
  3. Trailing commas and comments cause an exception being thrown
  4. The exception is not being caught/handled
  5. This makes the extension break/crash.
myfairsyer commented 5 years ago

These might (or might not) be helpful hints/links:

eamodio commented 5 years ago

@myfairsyer I'm not sure what code you are looking at but this extension DOES use the vscode configuration apis and doesn't parse any JSON directly.

What are the actual issues you are seeing?

eamodio commented 5 years ago

I am closing this issue because it needs more information and has not had recent activity. Please re-open this issue when more details can be provided.

Thanks!

myfairsyer commented 4 years ago

Sorry for not responding earlier.

IIRC I installed another similar extension alongside vscode-toggle-excluded-files which actually showed the behavior observed.

I just mixed them up and filed the issue in the wrong repo (and using the "wrong" name)

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.