search

eandersson / amqpstorm

Thread-safe Python RabbitMQ Client & Management library
MIT License
188 stars 36 forks source link

Update the supported versions of python3. #50

Closed smarlowucf closed 6 years ago

smarlowucf commented 6 years ago

I've been running AMQPStorm on 3.6 with no issues.

codecov-io commented 6 years ago

Codecov Report

Merging #50 into master will decrease coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage     100%   99.88%   -0.12%     
==========================================
  Files          29       29              
  Lines        1729     1729              
  Branches      258      258              
==========================================
- Hits         1729     1727       -2     
- Partials        0        2       +2
Impacted Files Coverage Δ
amqpstorm/compatibility.py 97.26% <0%> (-2.74%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a237674...302e214. Read the comment docs.

eandersson commented 6 years ago

Looks good! Thanks

Code coverage is failing due to a code path that no longer gets executed due to the removal of the 3.3 tests. I will follow up with a patch to fix that at a later date.

smarlowucf commented 6 years ago

Yep, I was about to push a change. 😄

Looks like the references to TLSv1 can be dropped as it's deprecated in 3.6 and 3.4 has support for v1_1 and v1_2.

https://github.com/eandersson/amqpstorm/blob/master/amqpstorm/compatibility.py#L52

eandersson commented 6 years ago

Ops! Feel free to drop another patch if you have time, but no hurry!