search

eandersson / amqpstorm

Thread-safe Python RabbitMQ Client & Management library
https://www.amqpstorm.io/
MIT License
186 stars 36 forks source link

unknown tag extra_setup #59

Closed bhoehl closed 6 years ago

bhoehl commented 6 years ago

@eandersson In setup.py the extra_setup tag causes a warning on installation using e.g. a tar gzipped version of your project. /usr/lib/python3.4/distutils/dist.py:260: UserWarning: Unknown distribution option: 'extra_require' This is a typo and should read extras_setup Please apply.

bhoehl commented 6 years ago

@eandersson I am not sure what this setup.py has to do with this error. That seems to me a different one. Please correct me if I am wrong.

FAIL: test_functional_connection_forcefully_closed (amqpstorm.tests.functional.web_based_tests.WebFunctionalTests)

Traceback (most recent call last): File "/home/travis/build/eandersson/amqpstorm/amqpstorm/tests/utility.py", line 274, in setup_wrapper result = f(self, *args, **kwargs) File "/home/travis/build/eandersson/amqpstorm/amqpstorm/tests/functional/web_based_tests.py", line 86, in test_functional_connection_forcefully_closed None, True, False AssertionError: AMQPConnectionError not raised by publish

eandersson commented 6 years ago

Thanks!

That test is unfortunately not fully functional and can be ignored for now.

bhoehl commented 6 years ago

@eandersson could you merge this, as I am currently refering to that git repo to install, as there is no new version for pip yet, ( I guess ) I am getting that warning when using pip install gitrepo every time again thanks!

eandersson commented 6 years ago

Yep was just waiting for the tests to rerun.