search

eandersson / amqpstorm

Thread-safe Python RabbitMQ Client & Management library
https://www.amqpstorm.io/
MIT License
186 stars 36 forks source link

Fixed potential race condition with publish confirms [#80] #81

Closed eandersson closed 4 years ago

eandersson commented 4 years ago

Fixed a potential race condition in the error handling of publish when confirming deliveries is enabled that could cause a valid connection error to bubble up too early making it look like the message wasn't successfully delivered.

codecov-commenter commented 4 years ago

Codecov Report

Merging #81 into master will increase coverage by 0.19%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #81      +/-   ##
===========================================
+ Coverage   99.80%   100.00%   +0.19%     
===========================================
  Files          20        20              
  Lines        1007      1007              
  Branches      117       117              
===========================================
+ Hits         1005      1007       +2     
+ Misses          1         0       -1     
+ Partials        1         0       -1
Impacted Files Coverage Δ
amqpstorm/io.py 100.00% <0.00%> (+1.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08577fc...d883a27. Read the comment docs.