search

eandersson / amqpstorm

Thread-safe Python RabbitMQ Client & Management library
https://www.amqpstorm.io/
MIT License
186 stars 36 forks source link

compatibility with pamqp>=3.0.0 #94

Closed MeggyCal closed 3 years ago

MeggyCal commented 3 years ago

sadly it is not compatible with pamqp2 anymore, it could possibly be done with a lot of try: ... except ImportError: ... constructs.

eandersson commented 3 years ago

This looks great. Thanks for the PR. I was a little hesitant to go to pamqp 3 because it is Python 3 only, and a lot of the amqpstorm users are still on python 2. I was thinking of either releasing amqpstorm version 3.0.0 as python 3 only, or maybe even releasing a new package called amqpstorm3.

Btw a lot of this work has been done in the feature/pamqp3 branch already. https://github.com/eandersson/amqpstorm/tree/feature/pamqp3

MeggyCal commented 3 years ago

sorry, I wasn't aware such a branch existed :) thanks for your comment, feel free to decline this PR in this case (it was mostly just sed -i 's/specification/commands/g' * anyway)

eandersson commented 3 years ago

Appreciate the time you spent to help out regardless @MeggyCal ! I'll start testing out pamqp 3. If you have some time feel free to pull it down and test it too.