gemini.util.RADecMath.string2Degrees would accept FK4 as FK5

eaobservatory / observing-tool

JCMT Observing Tool

1 stars 2 forks source link

gemini.util.RADecMath.string2Degrees would accept FK4 as FK5 #1

Open grahambell opened 10 years ago

grahambell commented 10 years ago

The code says:

// For now, assume everything is FK5/J2000
// Or FK4 - added by AB for ORAC 13-Oct-99
Assert.notFalse( ( coordSystem == CoordSys.FK5 ) || ( coordSystem == CoordSys.FK4 ) ) ;

But it does nothing else with coordSystem so coordinates supplied in FK4 will presumably be wrong.

timj commented 10 years ago

Right. The OT was never designed for Galactic coordinates. For most of the life of the OT it Galactic was specifically in the position editor for convenience but all other offsets were assumed to be J2000.