search

eaplatanios / tensorflow_scala

TensorFlow API for the Scala Programming Language
http://platanios.org/tensorflow_scala/
Apache License 2.0
936 stars 96 forks source link

SBT Install Documentation is incorrect #176

Closed clarkmalmgren closed 4 years ago

clarkmalmgren commented 4 years ago

SBT installation instructions are not using the scala version-specific instructions which are required. Specifically, libraryDependencies += "org.platanios" % "tensorflow" % "0.4.0" should be libraryDependencies += "org.platanios" %% "tensorflow" % "0.4.0"

There is a similar problem for the Precompiled Binaries.

Jazzpirate commented 4 years ago

Also: 0.4.1 by now :)

karlovolf commented 4 years ago

I would suggest opening PR for that since the solution you purposed is correct :)

stefanobaghino commented 4 years ago

Came up on this discussion on StackOverflow, I opened #183 to fix it. I'm not familiar with Paradox, I'm trying to test it but if you have any guidance I'd be happy to take suggestions. 😄

eaplatanios commented 4 years ago

@stefanobaghino I merged the PR and will be updating the website shortly. For future reference, if you want to test the changes made to the paradox site locally, you can use sbt docs/previewSite. :)

stefanobaghino commented 4 years ago

@stefanobaghino I merged the PR and will be updating the website shortly. For future reference, if you want to test the changes made to the paradox site locally, you can use sbt docs/previewSite. :)

Yeah, the problem was mostly that I know nothing about Tensorflow and the whole part of the build that depended on it failed. But thanks for checking for me and for welcoming the contribution! Cheers!