search

eaplatanios / tensorflow_scala

TensorFlow API for the Scala Programming Language
http://platanios.org/tensorflow_scala/
Apache License 2.0
937 stars 95 forks source link

fix: Fix tileGradient and make concatenateGradient work on OutputInde… #46

Closed carlo-veezoo closed 6 years ago

carlo-veezoo commented 6 years ago

I fixed a problem with tileGradient, where the shape was a scalar instead of a 1D Tensor. Also I made concatenateGradient work with OutputIndexedSlices, although naively. I left a TODO tag as it should be smarter in the long term.

eaplatanios commented 6 years ago

@csaladin94 I implemented a less naive version of that the concatenate op gradient for indexed slices. I'm not sure if it's fully bug free as I didn't have time to test it, but it should provide for a better base implementation to start with. I will thus close this pull request. Please create an issue if you find a bug with it. Thanks! :)

carlo-veezoo commented 6 years ago

@eaplatanios At least for me it works, the issue I had is gone, thanks a lot!