eaplatanios / tensorflow_scala

TensorFlow API for the Scala Programming Language
http://platanios.org/tensorflow_scala/
Apache License 2.0
936 stars 96 forks source link

Launch tensorboard binary directly making it work with python3 as well #60

Closed sbrunk closed 6 years ago

sbrunk commented 6 years ago

Also print warnings if tensorboard couldn't be found. This could also help with #58

Note that this still doesn't catch the possibility of TensorBoard starting but returning immediately with an error. Checking the exitcode is a bit more involved because it requires correct timing and dealing with threads.

It does cover the most common error case of having tensorboard not on the path though.

I've tested this with running sbt in a virtualenv with Python 2 and 3, respectively.

eaplatanios commented 6 years ago

That's great, thanks! :)