eapoland / landing-page

Nowa strona efektywnego altruizmu w Polsce
https://eapoland.github.io/landing-page/
0 stars 2 forks source link

article headings' highlighting should move accordingly #10

Closed agnespisz closed 6 years ago

agnespisz commented 6 years ago
  1. user clicks on an item in the sidebar - highlighting moves under the item on the sidebar and in the article
  2. user scrolls through article - highlighting moves on the sidebar and in the article accordingly to where the user is
screen shot 2017-10-30 at 10 34 16
agnespisz commented 6 years ago

please check as well: when you navigate to a heading from sidebar menu, the article moves not exactly to the place in the article (it moves directly to text, heading is not visible :( )

marcin-wosinek commented 6 years ago

the comment side will be addressed in #22

marcin-wosinek commented 6 years ago

Pretty likely time sink - in development & later on in maintenance (ie. fixing when ever gets broken when ever content is being updated).

For me it looks like a candidate for being postponed - until we will have all content put in; and we will have enough blog posts to be sure that: https://eapoland.github.io/landing-page/blog/post-1.html

doesn't need side bar.

agnespisz commented 6 years ago

blog posts will not have sidebar - they will have only sharing bar.

So it's needed only on Zacznij działać i Czym jest EA.

Can we at least bold&turquoise the sections on sidebar menu when chosen or scrolled to? With that, I will manage the rest :)

marcin-wosinek commented 6 years ago

probably to be addressed with: https://getbootstrap.com/docs/4.0/components/navs/

agnespisz commented 6 years ago

I guess so!

marcin-wosinek commented 6 years ago

To be checked at: https://eapoland.github.io/landing-page/czym-jest-ea.html#heading4

the same thing will be applied to /zacznij-dzialac.html after GH-20