earlSt1 / vtt-compendium-folders

Collapsable folders in the compendium directory and folder structures inside compendiums for FoundryVTT
21 stars 18 forks source link

Doesn't suppport more than 2 levels of folders #116

Open vynarim opened 2 years ago

vynarim commented 2 years ago

Describe the bug I have a 3 or 4 levels folder structure in my compendium to organize items and actors but it seems it causes errors saving content: not immedialely but after reload of FVTT or compendium, a lot of items are outsides the folder they were placed in

To Reproduce Create a 4 level deep folder structure Put several items in it Close FVTT and re open it open the compendium

Expected behavior Level of impricated folders should not be an issue

Screenshots image

Information

earlSt1 commented 2 years ago

Thanks for the report. I've been working on improving this aspect of the module and will be able to share a testing version soon to see if it fixes it.

earlSt1 commented 2 years ago

Hi, can you try using this testing version and see if it fixes it? You'll need to uninstall your current version of CF and install this one using this manifest link: https://raw.githubusercontent.com/earlSt1/vtt-compendium-folders/082-update/test/module.json

I strongly recommend backing up your compendiums/worlds just in case.

vynarim commented 2 years ago

Tests are ongoing, please just confirm this "test" version should appear as 2.3.53 (I uninstalled the current CF and installed the one from your Json link image

earlSt1 commented 2 years ago

Yep it will look like the same version

On Sat, 13 Nov 2021, 17:12 Jean-Rémy, @.***> wrote:

Tests are ongoing, please just confirm this "test" version should appear as 2.3.53 (I uninstalled the current CF and installed the one from your Json link [image: image] https://user-images.githubusercontent.com/20367460/141652705-ae1004ff-ace8-4bdc-a52c-2b54c54d6c82.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/earlSt1/vtt-compendium-folders/issues/116#issuecomment-968102133, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADI2CKD3TLVXSUFXTOIPC63UL2L6LANCNFSM5HPVMJSQ .

earlSt1 commented 2 years ago

Hi @vynarim any luck with testing?

vynarim commented 2 years ago

Hello @earlSt1 , Sorry for the delay, it was a crazy november for me

I dit some tests this morning but there is still an issue : after adding some items in my world and exporting them to the compendium, they were not added to the assiociated folder but to the root

In the following screenshot, the item "Aquilon..." was already in the folder and I added other ones now displayed at the root of the compendium

image

So I ressigned compendium root items in relevant folders but after exit and relauch of foundry, some items were again at root level

image

earlSt1 commented 2 years ago

Hi, I think I've finally found the cause of this issue. Can you try running the following command as a macro, then refreshing to see if it fixes it?

game.settings.set('compendium-folders','cached-folder',{});
dineshm72 commented 2 years ago

I don't know if this is related, but I have been having intermittent trouble with new things that were in new folders created in the world appearing in the root when newly exported to the compendium using "Export Folder Structure", and the folders which they were supposed to go into not appearing there. I thought it was a complicated problem due to hosting on the Forge, because I am not seeing the same problems in my local installation, but since I see the fix above deals with caching so perhaps it is related to that.

Essentially, the workaround fix I've discovered is to manually add a new folder in the compendium. Doing this causes the folder structure to get rebuilt somehow, and then magically the missing folders appear and all the stuff which had been in root gets put into the new folders as they should be.

I'm happy to try the setting above, but not sure if it requires the testing version too, which is a bit harder for me to do on the Forge.

earlSt1 commented 2 years ago

I don't know if this is related, but I have been having intermittent trouble with new things that were in new folders created in the world appearing in the root when newly exported to the compendium using "Export Folder Structure", and the folders which they were supposed to go into not appearing there. I thought it was a complicated problem due to hosting on the Forge, because I am not seeing the same problems in my local installation, but since I see the fix above deals with caching so perhaps it is related to that.

Essentially, the workaround fix I've discovered is to manually add a new folder in the compendium. Doing this causes the folder structure to get rebuilt somehow, and then magically the missing folders appear and all the stuff which had been in root gets put into the new folders as they should be.

I'm happy to try the setting above, but not sure if it requires the testing version too, which is a bit harder for me to do on the Forge.

Yep that sounds to me like a caching issue. I'm gonna try to find some time to fix it at the weekend. In the meantime that command above should make everything refresh properly (when you create a folder in the compendium, the cache is regenerated). You also dont need a testing version for it to work.

vynarim commented 2 years ago
game.settings.set('compendium-folders','cached-folder',{});

I launched the macro, nothing special happened and for the moment I didn't encounter the issue

image

dineshm72 commented 2 years ago

I'll also confirm that running the macro above seemed to fix the problem for me.