search

earlSt1 / vtt-compendium-folders

Collapsable folders in the compendium directory and folder structures inside compendiums for FoundryVTT
21 stars 18 forks source link

Compendium Folder Icons keep resetting #166

Closed Elmaro closed 1 year ago

Elmaro commented 1 year ago

Hi, so for some reason, my compendium folders keep resetting their images, and the image paths. no matter what I change it to, the folders reset to this (first image) image

The image doesn't actually exist, and I don't know why it is selected. I started a new world, only enabled the compendium folder module and the issue still persists. If I click on the folder icon, change it and update it, the image will change. But if I refresh the page, the image always reverts to that. If I delete "fa-solid:folder" and save, it returns to the default image, but if I refresh the page, it returns to the "fa-solid:folder"

Do you have any advice on what is going on?

Here is a video showing you what happens when I click stuff (With some smooth bossa nova to chill to as you watch) https://i.gyazo.com/c24dd356fb3d8f6ff49b9d074f6d4871.mp4

And another video showing some more things https://i.gyazo.com/e54df49c168de9a13bc02006ac5d3577.mp4

earlSt1 commented 1 year ago

Hi, I've had this reported a few times and i'm working on figuring out whats causing it. Thanks for the videos+screenshots.

I'm assuming you are on V10?

Elmaro commented 1 year ago

Hi, and thank you for the quick reply! Sorry, I should have mentioned, I am still on V9 right now. Will be for a while until some of the modules I use upgrade.

If there is anything else you need from me please let me know,

On Mon, 12 Sept 2022 at 17:50, Craig Earl @.***> wrote:

Hi, I've had this reported a few times and i'm working on figuring out whats causing it. Thanks for the videos+screenshots.

I'm assuming you are on V10?

— Reply to this email directly, view it on GitHub https://github.com/earlSt1/vtt-compendium-folders/issues/166#issuecomment-1244018264, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHAALGWQHNNXEWSPFY7KMTDV55NNXANCNFSM6AAAAAAQKPTWCI . You are receiving this because you authored the thread.Message ID: @.***>

earlSt1 commented 1 year ago

Gotcha, I think i see what is happening, but i'm not sure how its happening as i cant replicate it locally.

Do you think I could have access to your world so I can debug on there? You can ping me on discord with the details if thats ok (Erceron#0370)

Hawkeye131 commented 1 year ago

I am having this same issue on V10 clicking refresh seems to fix it but on restart its back it seems to be only on the GM side though.

I think this is the error

image

Elmaro commented 1 year ago

Hi, I'm so sorry for being so long in replying to this. I found out what the issue was. There are 2 modules that I installed that caused this problem to appear. Even after uninstalling one of them the problem continued to persist.

I am currently not with my computer so I am unable to check, but I will be hopefully tomorrow. I can then tell you what they were and hopefully this will help you in diagnosing the exact problem.

I did some troubleshooting and a lot of reinstalling blank systems to try and localise the problem so hopefully when I let you know the names of the modules, it will help

On Mon, 12 Sept 2022, 6:19 pm Craig Earl, @.***> wrote:

Gotcha, I think i see what is happening, but i'm not sure how its happening as i cant replicate it locally.

Do you think I could have access to your world so I can debug on there? You can ping me on discord with the details if thats ok (Erceron#0370)

— Reply to this email directly, view it on GitHub https://github.com/earlSt1/vtt-compendium-folders/issues/166#issuecomment-1244053207, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHAALGV4IENAJAS7LBJIH4LV55QZRANCNFSM6AAAAAAQKPTWCI . You are receiving this because you authored the thread.Message ID: @.***>

iotech-fvtt commented 1 year ago

@Elmaro What were the two modules you think are causing this?

earlSt1 commented 1 year ago

@Elmaro Are you hosting on the Forge by chance? There has been an issue fixed recently on their end related with compendiums that has caused issues with CF

Hawkeye131 commented 1 year ago

This issue is on self hosted as well. IDK about forge.

iotech-fvtt commented 1 year ago

Self hosted here too. On world load, the custom icons I chose are showing as broken image links. If I fix one of them, ALL of them are then correct (they're all different but in the same folder). I note that when theyre broken, the path in the Edit Folder dialog is the original path to fa-folder, but it can't find it. Maybe it is resetting to the mod folder rather than the User Data folder?

On Wed, Oct 5, 2022 at 7:53 PM Hawkeye @.***> wrote:

This issue is on self hosted as well. IDK about forge.

— Reply to this email directly, view it on GitHub https://github.com/earlSt1/vtt-compendium-folders/issues/166#issuecomment-1269204136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG5ZMEJNPORHAJYD3FLF3YTWBYWKBANCNFSM6AAAAAAQKPTWCI . You are receiving this because you commented.Message ID: @.***>

earlSt1 commented 1 year ago

Well fa-folder implies that theres some CSS shenanigans about, since that is the fontawesome class that represents the default folder icon, except i cant find anything in my code that would set that.

I have been looking into the issue but annoyingly its a real puzzler since i cant replicate it. Is someone else in this thread available to invite me to their game so I can debug there?

Elmaro commented 1 year ago

Hi, thank you for emailing me again to remind me, luckily I just got home last night (UK time zone)

So, there were two modules involved in the issue - the first was "Game-Icons.Net" by "thDM" https://eu.forge-vtt.com/bazaar/package/game-icons-net (Forge Link)

This was the module that forced folder icons to be replaced with "fa-folder" or whatever it was called.

And the second Module was Alpha Suite ( https://eu.forge-vtt.com/bazaar/package/alpha-suit) Even with Game-Icons.net uninstalled, Alpha suite would continuously force yout module to use "fa-" something

After removing both of those modules, and deleting their references, the issue resolved itself

I hope this helps, let me know if you need any more information

All the very best

Lamarr

On Tue, 4 Oct 2022 at 20:53, iotech-fvtt @.***> wrote:

@Elmaro https://github.com/Elmaro What were the two modules you think are causing this?

— Reply to this email directly, view it on GitHub https://github.com/earlSt1/vtt-compendium-folders/issues/166#issuecomment-1267506631, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHAALGXX5QYFBNIH23FZZ7LWBSDLDANCNFSM6AAAAAAQKPTWCI . You are receiving this because you were mentioned.Message ID: @.***>

earlSt1 commented 1 year ago

Fantastic!!! thats the module thats causing issues - Alpha suite.

I'll reach out to the module dev to see if i can resolve this. In the meantime you'll have to disable it.

earlSt1 commented 1 year ago

Raised an issue here: https://github.com/averrin/alpha-suit/issues/2

iotech-fvtt commented 1 year ago

I bumped it over there, thanks! In the meantime, I disabled Alpha Suite (I still have Compendium Browser and it works fine). Thanks, @earlSt1

earlSt1 commented 1 year ago

Looks like this is fixed in the latest update of Alpha Suite. Closing this for now

Hawkeye131 commented 1 year ago

This seems to be still a bug on this end. Even with alpha suit totally removed the error is still happening.

Confirmed it is happening even without anything else installed. @earlSt1

earlSt1 commented 1 year ago

This seems to be still a bug on this end. Even with alpha suit totally removed the error is still happening.

Confirmed it is happening even without anything else installed. @earlSt1

Hmm, have you tried with all modules off other than CF? and its still replacing the icons when you try to set them back to normal?

Hawkeye131 commented 1 year ago

Hmm, have you tried with all modules off other than CF? and its still replacing the icons when you try to set them back to normal?

Yes only using CF it still dose it

earlSt1 commented 1 year ago

Can you send me an invite to your world so i can have a look? My discord is @Erceron#0370

earlSt1 commented 1 year ago

For anyone else that has this issue that did have Alpha Suite installed when it was overwriting the folder icons, if you edit all folders with broken icons, delete the icon text field, and save, then it should be back to normal