earlSt1 / vtt-compendium-folders

Collapsable folders in the compendium directory and folder structures inside compendiums for FoundryVTT
22 stars 20 forks source link

Query values are persisted across all compendiums #36

Closed esb closed 3 years ago

esb commented 3 years ago

When a query filter is set for a compendium, then same query is applied to all compendiums that are opened subsequently. This is very confusing, as it looks like the function is broken as the compendiums will often show no data at all with the filter in place.

The filter is saved in the 'last-search' module setting which means it is persisted across game restarts, which can lead to even more confusion because it can hide all the entries if you don't notice that the search is still present.

I'd suggest that this behaviour is not intuitive, and the search filter should only apply to the compendium for which it was originally used. The filter should also be cleared on system restart.

earlSt1 commented 3 years ago

I thought I made it so the search term cleared whenever a new compendium was opened. I'll have another look at it soon thanks for pointing it out.

earlSt1 commented 3 years ago

Feature included in v2.1.8. Closing for now