search

earlSt1 / vtt-compendium-folders

Collapsable folders in the compendium directory and folder structures inside compendiums for FoundryVTT
22 stars 20 forks source link

Feature Request: Support for libWrapper #68

Closed Tupsi closed 3 years ago

Tupsi commented 3 years ago

I get lots of errors here on the user (read not GM) side having both TokenAttacher and Compendium Folders active. Wading threw both of your code it looks to me, like you are batteling for a hook called.

Hooks.on("getCompendiumDirectoryEntryContext",

and as I understand the concept of libWrapper, this would be on option to resolve the conflict.

https://github.com/ruipin/fvtt-lib-wrapper https://github.com/KayelGee/token-attacher

image

earlSt1 commented 3 years ago

I will be adding support for libwrapper, but i think this specific error is an implementation issue. I'll fix this in the next release.

earlSt1 commented 3 years ago

So i've currently got 0.8.2 checked out and cant test the 0.7.9 fix. Would you mind uninstalling your current version and installing this manifest to see if it solves it?

https://raw.githubusercontent.com/earlSt1/vtt-compendium-folders/master/test/module.json

Tupsi commented 3 years ago

Will do and report back tomorrow after testing.

Tupsi commented 3 years ago

Played around a bit with it and so far no more errors show up in the console. So I would say it looks good and thanks for the fix!

earlSt1 commented 3 years ago

Included in v2.2.43