earlSt1 / vtt-compendium-folders

Collapsable folders in the compendium directory and folder structures inside compendiums for FoundryVTT
21 stars 18 forks source link

creating a new module causes ghost duplicate folders to appear in the compendium window #86

Open wmve opened 3 years ago

wmve commented 3 years ago

steps to reproduce:

  1. open compendium image

  2. add new folder image

expected behaviour: new folder added to existing list of folders actual behaviour: observe ALL folders including new one duplicated

when i subsequently close the compendium and reopen it, it is looks as i expected it would have after step 2 image

here are the modules loaded. the third one is the compendium i'm creating folders in. image

earlSt1 commented 3 years ago

Hi, sorry for the wait, but i think i've found the issue. Can you try installing this test version and seeing if it fixes for you? To do so just uninstall your current version of compendium folders and install this one using the manifest field at the bottom of the install module screen: https://raw.githubusercontent.com/earlSt1/vtt-compendium-folders/082-update/test/module.json

wmve commented 3 years ago

sorry, that didn't change the behaviour. i followed your instructions above and tried to create a new folder. this is the result: [image: image.png] same as before. which, of course is not visible once i close and re-open the compendium.

On Sat, 3 Jul 2021 at 11:41, Craig Earl @.***> wrote:

Hi, sorry for the wait, but i think i've found the issue. Can you try installing this test version and seeing if it fixes for you? To do so just uninstall your current version of compendium folders and install this one using the manifest field at the bottom of the install module screen:

https://raw.githubusercontent.com/earlSt1/vtt-compendium-folders/082-update/test/module.json

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/earlSt1/vtt-compendium-folders/issues/86#issuecomment-873425898, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANK7YOJDELQVPDP7REK6KSTTV4VTTANCNFSM47PGWDVA .

wmve commented 3 years ago

[image: image.png] just for your confirmation of what i was testing with

On Sat, 3 Jul 2021 at 12:58, Marc van Es @.***> wrote:

sorry, that didn't change the behaviour. i followed your instructions above and tried to create a new folder. this is the result: [image: image.png] same as before. which, of course is not visible once i close and re-open the compendium.

On Sat, 3 Jul 2021 at 11:41, Craig Earl @.***> wrote:

Hi, sorry for the wait, but i think i've found the issue. Can you try installing this test version and seeing if it fixes for you? To do so just uninstall your current version of compendium folders and install this one using the manifest field at the bottom of the install module screen:

https://raw.githubusercontent.com/earlSt1/vtt-compendium-folders/082-update/test/module.json

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/earlSt1/vtt-compendium-folders/issues/86#issuecomment-873425898, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANK7YOJDELQVPDP7REK6KSTTV4VTTANCNFSM47PGWDVA .

earlSt1 commented 3 years ago

It looks like the image didnt attach correctly, can you try again maybe through Github?

wmve commented 3 years ago

will do

On Sat, 3 Jul 2021 at 15:56, Craig Earl @.***> wrote:

It looks like the image didnt attach correctly, can you try again maybe through Github?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/earlSt1/vtt-compendium-folders/issues/86#issuecomment-873462017, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANK7YOLK77MEZWWIKNDY5ITTV5TODANCNFSM47PGWDVA .

wmve commented 3 years ago

this is what it looked like when i tried again. behaviour doesn't appear to have changed. image

here the module entry in the modules list right now: image

earlSt1 commented 3 years ago

Thats a bit odd. It worked on my machine. I'll do some more testing tomorrow

Also the module version would look the same, the module code will be different though. Maybe i'll add some logging to check you've got the right version.