Misc updates to fix JS and URI syntax

mike42 commented 7 years ago

This pull request updates a few minor issues-

the main file contains a syntax error
the tests produce URI's with no scheme (the schemes key in the swagger format should be used if listed, while https is the best assumption if guessing). Based on the test cases, this may have been allowed in previous versions of the dependencies, but it gets me an exception.
test fixes for above
node_modules should be listed in the .gitignore file

Stack traces for the issues being fixed are shown below.

$ node -v
v6.9.5

Syntax issue:

$ node swagger-test.js 
/home/mike/workspace/swagger-test/swagger-test.js:24
      if (response.status && xample.responses[response.status] {
                                                               ^
SyntaxError: Unexpected token {
    at Object.exports.runInThisContext (vm.js:76:16)
    at Module._compile (module.js:542:28)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:509:3

Missing URI scheme:

$ node swagger-test.js < test/swagger.json 
Unhandled rejection Error: Invalid URI "localhost/v1/pets/fido4"
    at Request.init (/home/mike/workspace/swagger-test/node_modules/request/request.js:274:31)
    at new Request (/home/mike/workspace/swagger-test/node_modules/request/request.js:128:8)
    at request (/home/mike/workspace/swagger-test/node_modules/request/index.js:54:10)
    at tryCatcher (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/util.js:16:23)
    at ret (eval at makeNodePromisifiedEval (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promisify.js:184:12), <anonymous>:14:23)
    at /home/mike/workspace/swagger-test/node_modules/preq/index.js:181:38
    at tryCatcher (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/util.js:16:23)
    at Function.Promise.attempt.Promise.try (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/method.js:39:29)
    at Request.run (/home/mike/workspace/swagger-test/node_modules/preq/index.js:181:17)
    at Request.tryCatcher (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promise.js:510:31)
    at Promise._settlePromise (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promise.js:567:18)
    at Promise._settlePromise0 (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promise.js:612:10)
    at Promise._settlePromises (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promise.js:691:18)
    at Promise._fulfill (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promise.js:636:18)
    at Promise._resolveCallback (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promise.js:431:57)

Unhandled rejection Error: Invalid URI "localhost/v1/pets/fido7"
    at Request.init (/home/mike/workspace/swagger-test/node_modules/request/request.js:274:31)
    at new Request (/home/mike/workspace/swagger-test/node_modules/request/request.js:128:8)
    at request (/home/mike/workspace/swagger-test/node_modules/request/index.js:54:10)
    at tryCatcher (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/util.js:16:23)
    at ret (eval at makeNodePromisifiedEval (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promisify.js:184:12), <anonymous>:14:23)
    at /home/mike/workspace/swagger-test/node_modules/preq/index.js:181:38
    at tryCatcher (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/util.js:16:23)
    at Function.Promise.attempt.Promise.try (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/method.js:39:29)
    at Request.run (/home/mike/workspace/swagger-test/node_modules/preq/index.js:181:17)
    at Request.tryCatcher (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promise.js:510:31)
    at Promise._settlePromise (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promise.js:567:18)
    at Promise._settlePromise0 (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promise.js:612:10)
    at Promise._settlePromises (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promise.js:691:18)
    at Promise._fulfill (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promise.js:636:18)
    at Promise._resolveCallback (/home/mike/workspace/swagger-test/node_modules/bluebird/js/release/promise.js:431:57)

coveralls commented 7 years ago

Coverage decreased (-3.03%) to 96.97% when pulling 0774ddbb028fd7c3e2a330b2b55e3ea690d967cf on mike42:master into 0fdb62ff09b1c9b862b8f03343399ca1b67f28bf on earldouglas:master.

earldouglas commented 7 years ago

This is great; thanks a lot!

earldouglas commented 7 years ago

This is now released as version 0.7.0.

earldouglas / swagger-test

Misc updates to fix JS and URI syntax #14