Closed ayushsharma82 closed 1 month ago
You need to run tools/restyle.sh
to get the formatting correct for the repo here, and (void)
out an unused parameter to get through CI. OTW, seems nice and thanks for including an example!
Apparently, a lot of files weren't conforming to suggested format. I ran tests/restyle.sh
.
CI style check failed. Can this be due to different astyle
package version on my local machine? I have this on my PC: Artistic Style Version 3.5
.
Fixed example & formatting.
PS: I formatted WebServer folder only instead of whole library.
Weird about the astyle version differences, thx for fixing it. CI is using whatever the GH runner has installed which seems to match my own version for output (but not revision number).
For the callback build error, I haven't dug into it yet but in this core I split out the HTTPServer from the Webserver. This lets us support HTTPS and HTTP servers with no extra code. Separation of duties, the template (WebServer/WebServerSecure) handles incoming connections and passes it on to the HTTP parsing engine.
Fixed everything and tested locally. This should pass all CI tests.
Also, ESP32 PRs are merged therefore this PR is ready for merger too.
This PR implements filters and removable routes in RP2040 arduino core, making it API compatible with recent changes to ESP32 & ESP8266 WebServer API.
Reference (Recent additions to ESP32 WebServer API):
Reference (Recent addition to ESP8266 WebServer API):
Noteable Changes:
setFilter
)removeRoute
,removeHandler
,_removeRequestHandler
)