earlephilhower / arduino-pico

Raspberry Pi Pico Arduino core, for all RP2040 and RP2350 boards
GNU Lesser General Public License v2.1
2.05k stars 428 forks source link

build.mcu mentionned twice in boards.txt #380

Closed rei-vilo closed 2 years ago

rei-vilo commented 2 years ago

The build.mcu variable is mentioned twice in boards.txt.

Example for rpipico board

https://github.com/earlephilhower/arduino-pico/blob/7120a1508c09f8d409014552d4b7009106a58623/boards.txt#L20 https://github.com/earlephilhower/arduino-pico/blob/7120a1508c09f8d409014552d4b7009106a58623/boards.txt#L32

build.mcu is used for libraries distributed as pre-compiled binaries. This duplicate entry prevents from using that feature.

rei-vilo commented 2 years ago

See PR https://github.com/earlephilhower/arduino-pico/pull/381

earlephilhower commented 2 years ago

Thanks for the PR! I've combined your changes with the proper script changes and things should be working fine now w/binary libs.

rei-vilo commented 2 years ago

You're welcome!