earlygrey / shapedrawer

A library for libGDX that draws simple shapes using a batch.
MIT License
187 stars 31 forks source link

add polygon with offset methods, add drawing polygons as wireframe #57

Closed judos closed 2 years ago

judos commented 2 years ago
earlygrey commented 2 years ago

Hey thanks for the PR - I've tested it and have a couple of changes locally I'd like to add - what's the best way to do this? I can either push a commit to your fork somehow, or just make the commit in my repo after merging the PR.

Basically just using your added polygon method and calling polygon(vertices, triangles, trianglesCount, 0, 0) instead of duplicating the methods, and renaming and moving the wireframe method around a bit.

judos commented 2 years ago

I think it's easier if you commit it in your repo after merging the PR, but it doesn't really matter for me.

Is it easy to do a release after that? Then I could go back to using the official dependency instead of a local jar in my project :)

earlygrey commented 2 years ago

OK no problem - I'll merge it now and then will make another commit and a release when I get a chance.

By the way you can also just install your local working version of shape drawer to your local maven repository - use the install gradle command. You may have to adjust the version / dependency in your libgdx gradle setup, but then it will use the local installed version as the dependency.

earlygrey commented 2 years ago

@judos v2.6.0 - let me know if there's an issue