search

earnestt1234 / seedir

A Python package for creating, editing, and reading folder tree diagrams
MIT License
122 stars 9 forks source link

Make use of pytest for testing and use GitHub Actions #17

Open J535D165 opened 2 years ago

J535D165 commented 2 years ago

I think the pytest framework can be useful to test the package. It's more flexible and readable.

Also, making use of GitHub Actions would be nice.

earnestt1234 commented 2 years ago

Not very familiar with GitHub Actions, but seems nice :smile:. Having automatic testing on push or deployment to PyPI on release would be very nice.

And I am okay with moving to pytest if that is recommended or better for GitHub Actions. I didn't have a strong reason for going with unittest. I'm a little tied up for the next couple weeks but could revisit after that.

J535D165 commented 2 years ago

Nice, happy to review.

earnestt1234 commented 2 years ago

Didn't get around to addressing this for at all for the new version. Still planning to look into this, but will need to do some learning & testing

J535D165 commented 2 years ago

No worries. Version 0.4 is a nice improvement.

I'm working on a project, J535D165/scitree, which relies heavily on seedir. I want to propose some changes to the seedir API as I think they are both valuable for scitree and seedir. But the tests are holding me back at the moment. But there is no hurry for me :) Will work on this later.

earnestt1234 commented 2 years ago

That sounds great! Interested to hear your suggestions. Thanks for sharing your project, looks cool!

I generally want to improve/augment the testing suite for seedir. But still collecting my thoughts on what changes exactly. But I will port things to pytest as I am doing so

earnestt1234 commented 4 months ago

😪 Only took 2 years but finally made the tests pytest compatible: aeb1d25237283d582b26999cfd01f77d7df8d3c1. Should have just made ChatGPT do it.

@J535D165 not sure if you are still interested, but you can explore/propose your API changes now.

I still have not learned GitHub actions - still sounds appealing to me but haven't put the time in. I probably will not be able to pursue in the near feature, however, unless other changes necessitate it.

J535D165 commented 4 months ago

Great. Maybe I will look into it during my summer break in August.

timweissenfels commented 3 weeks ago

Hahaha, I just got a push notification for this issue, so crazy to see you guys revisiting this package 👍