earshinov / vscode-filter-lines

Extension for Visual Studio Code allowing to quickly find all lines matching a string or regular expression
https://marketplace.visualstudio.com/items?itemName=earshinov.filter-lines
MIT License
14 stars 3 forks source link

Folding should not happen not filtering with context #9

Closed baincd closed 3 years ago

baincd commented 3 years ago

Lines should not be folded in the following scenarios (even if foldIndentedContext is true)

earshinov commented 3 years ago

Makes sense. I will fix it within a few days. Thanks for reporting!

earshinov commented 3 years ago

@baincd , I just checked and it seems that foldIndentedContext already works as you described. Can you please provide detailed repro steps:

?

baincd commented 3 years ago

Hi @earshinov ,

Sure, no problem. Using the default settings (and other extensions disabled) image

When executing the "Exclude Lines with RegEx", after filtering the contents are folded

I expected the file to not be folded (folding should happen only when using one of the "...and Context" commands)

The folding occurs (but should not):

Thanks!

earshinov commented 3 years ago

Should be fixed in v1.0.0. Please let me know if you have any problems.

baincd commented 3 years ago

Perfect, thank you!