search

earth-genome / coastal-valuation

A web service to assess the expected value of real estate under sea level rise
1 stars 0 forks source link

Convert to Flask #13

Open kramachandran opened 8 years ago

kramachandran commented 8 years ago

@danhammer - Happy to tackle this or you can. I will have time this weekend (saturday/sunday)

danhammer commented 8 years ago

If I can't devote time before the weekend, then please feel free -- maybe as part of the docker factor/refactor. I am more than happy to help and document if I am unable to start tackling this issue before you have a chance. I will post to this thread just before I start (if I start before I hear back from you).

danhammer commented 8 years ago

@kramachandran I've started this process with a working version of the flask/docker stack on the branch feature/flask-refactor. I am going to combine the two issues (#13 and #12) into one, which can be closed when we merge the forthcoming pull request.

danhammer commented 8 years ago

You can run this stuff with the following commands:

docker-compose build
docker-compose up
docker-machine ip default

Navigate to the IP address in the returned result (which for me is 192.168.99.101) and the port 5000. For example http://192.168.99.101:5000.

danhammer commented 8 years ago

Ensuring that this feature doesn't fall off the radar.

self.response.headers.add_header("Access-Control-Allow-Origin", "*")
self.response.headers['Content-Type'] = 'application/json'

I am unsure how to set these headers in the Flask framework. I expect that the solution is in line with Nginx.

danhammer commented 8 years ago

I don't sufficiently understand this post, although it seems relevant. Maybe not now -- premature optimization and complexity -- but I like the idea of adding seemingly extra features to this web service up front, given the plans to make it broader.