earth-genome / foodtwin-global-app

Repository for our work on the global foodtwin application.
MIT License
1 stars 0 forks source link

Add food-produced bar chart #80

Closed oliverroick closed 1 month ago

oliverroick commented 1 month ago

Adds the food-produced bar chart to the area page

Screenshot 2024-10-21 at 18 15 02
vgeorge commented 1 month ago

@oliverroick I did a quick function review and wasn't able to see more then one food group listed for areas that should have them. I tried Québec but it doesn't show any bars:

Screenshot 2024-10-22 at 13 26 28

Do you know of any other areas that have more than one food group and are working as intented?

oliverroick commented 1 month ago

@vgeorge Here's one with two groups: http://localhost:3000/area/CRI.1_1 I did notice that the data overall is quite sparse. I'm basing the data on the exports from the area, and many areas don't seem to export anything at all or they only export two food groups max.

vgeorge commented 1 month ago

@oliverroick I looked into the area you referred to and it displayed the data correctly; this looks good. We might need an empty state for when there is no flow data available, for which I ticketed in separate in https://github.com/earth-genome/foodtwin-global-app/issues/85.

With the merge to #78 there are conflicting changes with this. I tried to solve it, but it seemed that I was introducing regressions in your work. Would you be able to merge develop into this?

oliverroick commented 1 month ago

@vgeorge I've sorted out the merge conflict here.