search

earth-mover / icechunk

Open-source, cloud-native transactional tensor storage engine
https://icechunk.io
Apache License 2.0
295 stars 18 forks source link

Removed "await" from era5 notebook to get it running #296

Closed rsignell closed 1 month ago

rsignell commented 1 month ago

When I tried first running the era5 notebook linked in the blog post, I was getting errors like:

TypeError: object IcechunkStore can't be used in 'await' expression

I didn't really know what I was doing, but when I removed the await references, I got the notebook to run (using a Coiled Jupyterlab instance on AWS) and the performance seemed similar to Ryan's original results?

jhamman commented 1 month ago

Thanks @rsignell - we can take another pass through these notebooks and clean this up. We just changed the store this week to use asynchronous API for the create/open/commit methods.

and the performance seemed similar to Ryan's original results?

Great stuff!

rsignell commented 1 month ago

No, icechunk is the great stuff!! 😜