search

earth-system-radiation / rte-rrtmgp

RTE+RRTMGP is a set of codes for computing radiative fluxes in planetary atmospheres.
BSD 3-Clause "New" or "Revised" License
74 stars 67 forks source link

Develop #223

Closed m214089 closed 1 year ago

m214089 commented 1 year ago

Hi Robert, this is the pull request for the gas optics problem mentioned in #214 . Hope I did things correct! Cheerio, Luis

m214089 commented 1 year ago

I explained the change in a comment in the code as the the programming style is not followed, hopefully preventing changes back.

m214089 commented 1 year ago

Hmmm, CI is strange: ifx - internal compiler error, cce-gpu-xxx -data missing or incorrect read. All this is nothing where I have any control over and for sure not related to my changes ...

RobertPincus commented 1 year ago

@m214089 The CI failures are "expected" - the OpenMP GPU offload implementation has never worked on either Cray CCE nor Intel IFX.