search

earth-system-radiation / rte-rrtmgp

RTE+RRTMGP is a set of codes for computing radiative fluxes in planetary atmospheres.
BSD 3-Clause "New" or "Revised" License
74 stars 67 forks source link

Cray compiler supports nowadays no_create #226

Closed jussienko closed 1 year ago

jussienko commented 1 year ago

Additional workarounds are still needed for getting the code to run with Cray compiler. However, this actually fixes issues in the code, so it might be nice to get this into the main code.

RobertPincus commented 1 year ago

@vectorflux @fomics These fixes were originally yours, I believe. Any objections to the changes?

jussienko commented 1 year ago

Since CCE 15.0.0 no_create is supported. The default CCE in LUMI is 15.0.0, and 15.0.1 is also available via normal module system.

The current #ifdefs do not actually even work as all the variables are not necessarily present (I guess that's why no_create's are used in the first place :-) ).

vectorflux commented 1 year ago

Good. We have the go ahead from Jussi, so these changes are fine.