search

earth-system-radiation / rte-rrtmgp

RTE+RRTMGP is a set of codes for computing radiative fluxes in planetary atmospheres.
BSD 3-Clause "New" or "Revised" License
74 stars 65 forks source link

Simplify LW source functions #250

Closed RobertPincus closed 8 months ago

RobertPincus commented 8 months ago

The original formulation of RRTMGP uses separate spectral maps for upwelling and downwelling radiation at each level. Here they are combined as sqrt(map1 * map2). This reduces memory traffic between gas optics and solver by about 25% and makes the solvers more generic.

Differences introduced to the test cases are of order 0.06 W/m2. This exceeds the threshold we've been using to check for equivalence (7e-4). In this iteration the threshold has been relaxed to allow the tests to pass - is this the right approach, or would it be better to establish new test data?

RobertPincus commented 8 months ago

@alexeedm I'm especially interested in any thoughts you have on the GPU implementation

RobertPincus commented 3 months ago

Flux-errors Net-and-max-flux-error

Long after the fact, here are comparisons of accuracy for present-day RFMIP atmospheres