search

earth-system-radiation / rte-rrtmgp

RTE+RRTMGP is a set of codes for computing radiative fluxes in planetary atmospheres.
BSD 3-Clause "New" or "Revised" License
74 stars 65 forks source link

Fix the intent in lw_transport_noscat_up #261

Closed skosukhin closed 6 months ago

skosukhin commented 6 months ago

This should make the nag-cpu-accel-DP CI job pass (as soon as Levante is back online).

The wrong intent leads to the multiplication by NaN here.

RobertPincus commented 6 months ago

@skosukhin Got it! Because the boundary condition was applied to flux_up the argument has to be inout. Excellent catch, thanks to you and to NAG.

Do you mind to also make the change to the CPU kernel as part of this PR?

RobertPincus commented 6 months ago

Scratch that request, @skosukhin, as you point out the intent is already correct in the CPU kernel.