earth-system-radiation / rte-rrtmgp

RTE+RRTMGP is a set of codes for computing radiative fluxes in planetary atmospheres.
BSD 3-Clause "New" or "Revised" License
74 stars 65 forks source link

Get rid of red crosses in the CI reports #267

Closed skosukhin closed 6 months ago

skosukhin commented 6 months ago

This should be the first PR in a long time without the annoying red crosses in the CI report.

Several jobs in our CI workflows are known to fail. Currently, we set continue-on-error: true for them. This makes at least the workflow status green. However, the red crosses pop up in the PR and commit CI reports. Getting used to them does not look like a good idea to me. One way of dealing with it is to simply remove the jobs. That would be fine with me but I accept the arguments for keeping them.

Job cce-gpu-openmp is known to fail at the runtime. This PR changes it so that it is marked green if it does fail at the runtime and is considered as failed otherwise. That is, the job fails the whole Self-hosted CI workflow if it does NOT fail against the expectations.

The ifx+accel jobs are known to fail at the build time due to internal compiler errors. This PR changes them so that they are marked green if they fail at the build time with the Internal compiler error substring in the build log. In all other cases, the jobs fail the whole Continuous integration in a box.