search

earthcubeprojects-chords / chords

EarthCube CHORDS application code
GNU General Public License v2.0
25 stars 13 forks source link

docker-compose pull behavior broken #554

Closed MisterMartin closed 4 years ago

MisterMartin commented 4 years ago

Docker-compose pull behavior changed with v1.25. Now, if both 'build' and 'image' are present in docker-compose.yml, docker-compose will always try to build the image when you do an "up". If you specify --no-build, it will not try to pull/update the image. Likewise, a pull doesn't try to pull missing images if 'build' and 'image' are present. See here.

This hoses the behavior of chords_control.

MisterMartin commented 4 years ago

An easy fix. Just put the build configuration in a supplemental docker-compose-build.yml file, and use the following when building images:

docker-compose -f docker-compose.yml -f docker-compose-build.yml build
# or
docker-compose -f docker-compose.yml -f docker-compose-build.yml build <service>

Corrected in bb77ade566e5092c4e281520927068a8fdbb416c.