earthcubeprojects-chords / chords

EarthCube CHORDS application code
GNU General Public License v2.0
25 stars 13 forks source link

chords_control script fails and needs updated docker registry #581

Closed kmaull-ucar closed 1 year ago

kmaull-ucar commented 2 years ago

Script fails to install due to old v1 URL.

New URL should be:

https://registry.hub.docker.com/v2/repositories/earthcubechords/chords/tags

in L688 needs the updated URL:

        self.dockerhub_tags_uri = "https://registry.hub.docker.com/v1/repositories/earthcubechords/chords/tags" # OLD URL DOES NOT WORK

and L691 needs updating, but the V2 registry entry does not exist (needs to be created???).

Furthermore L821 needs to reflect the new JSON of V2:

        for tag in json.loads(curl_result):

SHOULD BE

        for tag in json.loads(curl_result)['results']:
MisterMartin commented 1 year ago

This has been fixed and pushed to the development branch.

Thanks Keith!

On Nov 22, 2022, at 10:51 AM, kmaull-ucar @.***> wrote:

for tag in json.loads(curl_result)['results']:

MisterMartin commented 1 year ago

Fixed in 4a1c16e009efc40a2fc08a5415708d1cc006f95e.