search

earthcubeprojects-chords / chords

EarthCube CHORDS application code
GNU General Public License v2.0
25 stars 13 forks source link

Is docker required in the chords_app image #585

Open MisterMartin opened 1 year ago

MisterMartin commented 1 year ago

The Dockerfile (RUN curl -sSL https://get.docker.com/) installs docker within the chords_app image. This was required for some sort of inter-container coordination back in the day, but is it required anymore?

MisterMartin commented 1 year ago

It looks like it is used for the config page database export/import function (profiles_controller.rb: export_influxdb and import_influxdb. I think this may be available via http; but perhaps we should just leave it as is for now.

mdye commented 1 year ago

There are a couple of other places that do a "docker exec" from within the (Rails) code:

app/controllers/profiles_controller.rb: This is the bulk export capability. When I developed this I looked in to the http option, but funneling all the data over http between containers was a huge performance hit and consumed a lot more memory.

bin/certbot/renew_hooks.sh : reloading the nginx container

I thikn this should be left in place, as much as I'd like to decrease the size of the container.

MisterMartin commented 1 year ago

Need to remind me how the bulk influxdb import/export works. It would require a parallel dump/restore of mysql, right? What was the use case for this?

We now have the chords_control backup/restore functions, for complete portal backups. Does this duplicate the browser export?

Also, what is the reference to “bin/certbot/renew_hooks.sh : reloading the nginx container” about? I think that has to do with renewing ssl certs.