earthdata-owner / test-repo-A

Test Repo A for Tasktop integration
0 stars 0 forks source link

Buttons in Pull Requests do nothing #34

Closed ccuadrado closed 2 years ago

ccuadrado commented 2 years ago

I was review the attached pull request as mike.mcgann but cannot seem to do anything. The Merge, Decline, Edit, and Approve buttons do not seem to do anything.

I tried to go back to remove that pull request (sent as mike.mcgann.urs1), and the decline button there doesn't work either.

ccuadrado commented 2 years ago

(Comment from Brett McLaughlin):

Updating and removing from 0.2.0, since while we want to support pull requests in 0.2.0, it's not absolutely essential for release.

ccuadrado commented 2 years ago

(Comment from Nevin Apondo):

ccuadrado commented 2 years ago

(Comment from Joe Manfre):

I've attached (as "error_console.png") the JavaScript loading errors I saw when loading the page in question.

ccuadrado commented 2 years ago

(Comment from Nevin Apondo):

I saw the same errors when working with the git-sit stash but not when working with the local instance. So presumably there is something about the git-sit configuration that is affecting js execution. I have sent a console capture to Atlassian though

ccuadrado commented 2 years ago

(Comment from Joe Manfre):

Here's the full URLs for the two JavaScript files referenced, in the order that they're loaded:

https://git-sit.echo.nasa.gov/s/enUS-1988229788/9f6e2ca/1/1//download/superbatch/js/batch.js

https://git-sit.echo.nasa.gov/s/enUS-1988229788/9f6e2ca/1/19c8fbdc0080c96769bbf571fb7c0e0e//download/contextbatch/js/stash.page.pullRequest.view,stash.layout.pullRequest,stash.layout.repository,stash.layout.base,atl.general,stash.layout.entity/batch.js

ccuadrado commented 2 years ago

(Comment from Joe Manfre):

If I'm reading this right, I think the second script (the one with the really really long URL) is failing because it is trying to use an undefined "WebFragments" object, and then the script with the not-as-long URL fails because it is trying to use things that are supposed to be defined in the failed script. So where is the WebFragments object supposed to come from?

ccuadrado commented 2 years ago

(Comment from Mike McGann):

This is probably related to DRAG-263.